Re: [PATCH] perf tools: mark branch_info maps as referenced

From: Jiri Olsa
Date: Mon Jan 14 2013 - 09:18:07 EST


On Mon, Jan 14, 2013 at 03:02:45PM +0100, Stephane Eranian wrote:
>
> As noticed by Jiri, the hist_entry->branch_info.to/from maps
> need to be marked as referenced to avoid problems later on.
> So we do this when the hist_entry is allocated.
>
> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

> --
>
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index cb17e2a..ab35b82 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -242,6 +242,14 @@ static struct hist_entry *hist_entry__new(struct hist_entry *template)
>
> if (he->ms.map)
> he->ms.map->referenced = true;
> +
> + if (he->branch_info) {
> + if (he->branch_info->from.map)
> + he->branch_info->from.map->referenced = true;
> + if (he->branch_info->to.map)
> + he->branch_info->to.map->referenced = true;
> + }
> +
> if (symbol_conf.use_callchain)
> callchain_init(he->callchain);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/