Re: [PATCH v7u1 24/31] x86, boot: Not need to check setup_headerversion for setup_data

From: Borislav Petkov
Date: Mon Jan 14 2013 - 06:26:08 EST


On Thu, Jan 03, 2013 at 04:48:44PM -0800, Yinghai Lu wrote:
> That is for bootloader.
>
> setup_data is in setup_header, and all bootloader is copying that
> for bzImage. So for old bootloader should keep that as 0.

Are you sure all old bootloaders have kept setup_data as 0 so that you
can drop the check.

And besides, the check doesn't hurt but prevents insane old boot loaders
from handing in crap into the kernel so I'd leave it in.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/