Re: [PATCH v7u1 21/31] x86, kexec: only set ident mapping for ram.

[Borislav Petkov]

On Sun, Jan 13, 2013 at 09:46:17PM -0800, Yinghai Lu wrote:
> On Sun, Jan 13, 2013 at 4:56 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > On Thu, Jan 03, 2013 at 04:48:41PM -0800, Yinghai Lu wrote:
> >> We should not set mapping for all under max_pfn.
> >
> > "We should not establish mappings for all memory under max_pfn."
> 
> that is not accurate.
> 
> We should not set mapping for all range under max_pfn.
> 
> or
> 
> We should set mappings only for memory ranges under max_pfn.

Ok, that last thing is getting close. So do I understand it correctly
now:

"We should establish mappings only for memory (memory which is not
marked reserved or whatever by E820 or some other mechanism) under
max_pfn."

?

> >> That causes same problem that is fixed by
> >
> > "Otherwise, it causes the same ..."
> >
> >>
> >>       x86, mm: Only direct map addresses that are marked as E820_RAM
> >
> > You could add this patch's commit id since it is in tip:x86/mm2 and it
> > shouldn't change: 66520ebc2df3.
> 
> why ? they are not in linus tree yet, so it could change if that tip
> branch is rebased.

Oh, you didn't know: tip branches don't get rebased. At least almost
never.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/