Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

From: Borislav Petkov
Date: Sat Jan 12 2013 - 19:03:09 EST


On Sat, Jan 12, 2013 at 01:13:23PM -0800, Andrew Morton wrote:
> Florian has been taking a month or two's downtime (now expired, I
> think) so I've been waiting for him to reappear to process this one for
> 3.8.
>
> Meanwhile, I guess we could put it into mainline ;) It has been in
> -next for a month.
>
> From: Alan Cox <alan@xxxxxxxxxxxxxxx>
> Subject: fb: rework locking to fix lock ordering on takeover
>
> Adjust the console layer to allow a take over call where the caller
> already holds the locks. Make the fb layer lock in order.
>
> This is partly a band aid, the fb layer is terminally confused about the
> locking rules it uses for its notifiers it seems.
>
> [akpm@xxxxxxxxxxxxxxxxxxxx: remove stray non-ascii char, tidy comment]
> [akpm@xxxxxxxxxxxxxxxxxxxx: export do_take_over_console()]
> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@xxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Yes, that's the one, modulo Andrew's fixes, which I've been running.
Irregardless, I'll run this one tomorrow just in case, because it
triggers here so easily.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/