Re: regression, bisected: openpty fails from 3.7 onwards withoutdevpts

From: Alan Cox
Date: Fri Jan 11 2013 - 07:57:33 EST


On Fri, 11 Jan 2013 13:44:22 +0100
Jiri Slaby <jslaby@xxxxxxx> wrote:

> On 01/11/2013 01:41 PM, Florian Westphal wrote:
> > Jiri Slaby <jslaby@xxxxxxx> wrote:
> >> On 01/10/2013 11:51 PM, Jiri Slaby wrote:
> >>> On 01/10/2013 11:45 PM, Alan Cox wrote:
> >>>> So we should just fix TIOCGPTN on a pty with no suitable name
> >>>> answer to return -EINVAL
> >>>
> >>> Yes, I agree as I'm expressed in my second mail. Sorry for the
> >>> confusion.
> >>
> >> Does the attached patch help?
> >
> > Yes, it does. Thanks for fixing this.
>
> Ok, now I'm not sure if we want the patch or to implement TIOCGPTN
> properly instead. Alan?

IMHO - fix now for the -rc tree where its clearly low risk, after that
whatever people feel like doing 8)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/