Re: [PATCH v3 07/22] sched: set initial load avg of new forked task

From: Alex Shi
Date: Fri Jan 11 2013 - 00:43:04 EST


On 01/11/2013 01:10 PM, Preeti U Murthy wrote:
>> > update_curr(cfs_rq);
>> > - enqueue_entity_load_avg(cfs_rq, se, flags & ENQUEUE_WAKEUP);
>> > + enqueue_entity_load_avg(cfs_rq, se, flags);
>> > account_entity_enqueue(cfs_rq, se);
>> > update_cfs_shares(cfs_rq);
>> >
> I had seen in my experiments, that the forked tasks with initial load to
> be 0,would adversely affect the runqueue lengths.Since the load for
> these tasks to pick up takes some time,the cpus on which the forked
> tasks are scheduled, could be candidates for "dst_cpu" many times and
> the runqueue lengths increase considerably.
>
> This patch solves this issue by making the forked tasks contribute
> actively to the runqueue load.
>
> Reviewed-by:Preeti U Murthy
>

Thanks for review, Preeti! :)


--
Thanks Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/