Re: linux-next: Tree for Jan 10 (staging/sb105x)

From: Steven Rostedt
Date: Thu Jan 10 2013 - 15:50:47 EST


On Thu, 2013-01-10 at 11:08 -0800, Randy Dunlap wrote:
> On 01/09/13 19:32, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20130109:
> >
>
> on x86_64, when CONFIG_PARPORT_PC is not enabled:
>
> drivers/built-in.o: In function `multi_init':
> sb_pci_mp.c:(.init.text+0x15684): undefined reference to `parport_pc_probe_port'
>
>
> Full randconfig file is attached.

Ug, so https://lkml.org/lkml/2012/12/14/250 should have been
CONFIG_PARPORT_PC and not just PARPORT :-P

Can you try this patch:

diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
index 131afd0c..9464f38 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -3054,7 +3054,7 @@ static int init_mp_dev(struct pci_dev *pcidev, mppcibrd_t brd)
sbdev->nr_ports = ((portnum_hex/16)*10) + (portnum_hex % 16);
}
break;
-#ifdef CONFIG_PARPORT
+#ifdef CONFIG_PARPORT_PC
case PCI_DEVICE_ID_MP2S1P :
sbdev->nr_ports = 2;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/