srat: harsh hot-pluggable memory check?

From: Davidlohr Bueso
Date: Thu Jan 10 2013 - 14:41:37 EST


When parsing the memory affinity mappings in arch/x86/mm/srat.c:
acpi_numa_memory_affinity_init() I'm wondering if the hot-pluggable check is too harsh,
as we consider an error if the hot-pluggable bit is set and CONFIG_MEMORY_HOTPLUG is not.

Based on the ACPI specs (v5):

"If the Enabled bit is set and the Hot Pluggable bit is also set. The
system hardware supports hot-add and hot-remove of this memory
region."

This only mentions that the system supports hot-plugging, and IMHO if the
user decides not to use CONFIG_MEMORY_HOTPLUG, it shouldn't be considered an error.
Therefore would it be ok to drop the check? Or am I missing something?

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/