Re: [PATCH resend 2/2] Input: twl6040-vibra: Code cleanup in probewith devm_* conversion

[Dmitry Torokhov]

Hi Peter,

On Thu, Jan 10, 2013 at 02:36:05PM +0100, Peter Ujfalusi wrote:
> Convert the probe to use devm_*. At the same time reorder the calls
> so we will register the input device as the last step when the driver
> is loaded.

If you are doing this please also use devm_input_allocate_device() and
devm_regulator_bulk_get(). I alos think it is high time to get rid of
dedicated work queue - cwq hasn't actually given you a separate therad
for a while now and if you get rid of workqueue you can get ridof entire
twl6040_vibra_remove().

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/