Re: [PATCH v3] gpio: twl4030: Cache the direction and output statesin private data

From: Peter Ujfalusi
Date: Thu Jan 10 2013 - 08:09:25 EST


Hi Linus,

On 01/10/2013 11:41 AM, Linus Walleij wrote:
> On Thu, Dec 20, 2012 at 10:44 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:
>
>> Use more coherent locking in the driver. Use bitfield to store the GPIO
>> direction and if the pin is configured as output store the status also in a
>> bitfiled.
>> In this way we can just look at these bitfields when we need information
>> about the pin status and only reach out to the chip when it is needed.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> ---
>> Hi Grant,
>>
>> Changes sicne v2:
>> - Fixed the mutex_unlock found by Michael.
>> - Removed the debug prints addedd by v2 patch (remains from debugging)
>> - Removed one blank line between includes and the first comment section.
>
> Sorry Peter this must have been missed somehow.
>
> This does not apply to the current v3.8-rc3, could you respin
> this on top of Torvalds' tree?

Grant applied the patch which this one depends on:
[1] https://patchwork.kernel.org/patch/1844511/

Not sure where.
There were a third patch in v2 as well. I'm not sure about the status of that.

[1] + this patch applies cleanly on top of mainline.

Should I resend the series as v4 for your convenience?

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/