RE: [PATCH] leds-lm355x: support LED trigger functionality

[Kim, Milo]

> -----Original Message-----
> From: Bryan Wu [mailto:cooloney@xxxxxxxxx]
> Sent: Thursday, January 10, 2013 10:16 AM
> To: Kim, Milo
> Cc: Jeong, Daniel; gshark.jeong@xxxxxxxxx; linux-leds@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] leds-lm355x: support LED trigger functionality
> 
> On Mon, Jan 7, 2013 at 10:35 PM, Kim, Milo <Milo.Kim@xxxxxx> wrote:
> >  LM355x family devices provide flash, torch and indicator functions.
> >  This patch support LED trigger feature.
> >  Using LED trigger APIs(), other driver simply turn on/off the flash,
> torch
> >  and indicator.
> >
> >  Platform data
> >   the name of LED trigger is configurable.
> >
> >  Documentation
> >   example and detailed description added.
> >
> > Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
> > ---
> >  Documentation/leds/leds-lm3556.txt        |   62
> +++++++++++++++++++++++++++++
> >  drivers/leds/leds-lm355x.c                |    3 ++
> >  include/linux/platform_data/leds-lm355x.h |    8 ++++
> >  3 files changed, 73 insertions(+)
> >
> > diff --git a/Documentation/leds/leds-lm3556.txt
> b/Documentation/leds/leds-lm3556.txt
> > index d9eb91b..73244cd 100644
> > --- a/Documentation/leds/leds-lm3556.txt
> > +++ b/Documentation/leds/leds-lm3556.txt
> > @@ -83,3 +83,65 @@ and register it in the platform init function
> >  Example:
> >         board_register_i2c_bus(4, 400,
> >                                 board_i2c_ch4,
> ARRAY_SIZE(board_i2c_ch4));
> > +
> > +Support LED Triggers
> > +--------------------
> > +Flash, torch and indicator can be controlled not only by an user-
> space but also
> > +by other drivers, kernel space.
> > +For example, flash turns on by camera driver internally.
> > +To support this functionality, LED trigger is registered.
> > +The name of LED trigger is configurable in the platform data.
> > +
> > +Example: LED trigger name for flash
> > +#include <linux/platform_data/leds-lm355x.h>
> > +
> > +struct lm355x_trigger_name lm3556_trigger_name = {
> > +       .flash = "flash",
> > +};
> > +
> > +struct lm355x_platform_data lm3556_pdata = {
> > +       ...
> > +       .trigger = &lm3556_trigger_name,
> > +};
> > +
> > +Example: Flash control in simple camera driver
> 
> Hi Milo,
> 
> Can we share this camera flash trigger with other users? just
> introduce a new trigger in drivers/leds/ledtrig-flash.c,
> drivers/leds/ledtrig-torch.c, drivers/leds/ledtrig-indicator.c. So it
> can shared by plenty of users.
> 
> And this trigger can be independent with LM355x and use other LED
> hardware driver underneath.
> 
> So I expect such trigger driver instead of a specific trigger in LED
> hardware driver and in other subsystem.

Good idea, Bryan. Thanks!
Then added name field of lm355x platform data can be gone and driver is
replaced with fixed name field.
And how about gathering ledtrig-* drivers in new subdirectory under drivers/leds
?(eg. drivers/leds/trigger/)

Best Regards,
Milo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/