Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is notenough ram for it

[Yinghai Lu]

On Wed, Jan 9, 2013 at 1:00 PM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
> Yinghai Lu <yinghai@xxxxxxxxxx> writes:
>
>> please check updated attached. It should address all your request.
>
> There is one significant bug that I can see.
>
> swiotlb_print_info tests no_iotlb_memory but no_iotlb_memory is set
> after swiotlb_init_with_tlb returns.

there is another swiotlb_print_info calling from
pci_swiotlb_late_init

void __init pci_swiotlb_late_init(void)
{
        /* An IOMMU turned us off. */
        if (!swiotlb)
                swiotlb_free();
        else {
                printk(KERN_INFO "PCI-DMA: "
                       "Using software bounce buffering for IO (SWIOTLB)\n");
                swiotlb_print_info();
        }
}

so we need that checking when swiotlb == 1, but actually we can not
allocate that before.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/