Re: [PATCH v7u1 26/31] x86: Don't enable swiotlb if there is notenough ram for it

From: Yinghai Lu
Date: Wed Jan 09 2013 - 12:27:35 EST


On Wed, Jan 9, 2013 at 5:24 AM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Jan 08, 2013 at 05:12:02PM -0800, Yinghai Lu wrote:
>> On Tue, Jan 8, 2013 at 5:07 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> > On Tue, Jan 8, 2013 at 4:58 PM, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>> >
>> >>
>> >> So instead we need to say?
>> >>
>> >> + if (no_iotlb_memory)
>> >> + panic("Cannot allocate SWIOTLB buffer");
>> >> +
>> >>
>> >> Which is just making the panic a little later than it used to be and
>> >> seems completely reasonable.
>> >
>> > yes, looks some driver just use map_single without checking results.
>>
>> update one.
>
> Please make it inline.
>

please check updated attached. It should address all your request.

Thanks

Yinghai

Attachment: swiotlb.patch
Description: Binary data