Re: [PATCH 5/6] udf: implement extent caching while reading-writingto a file

From: Namjae Jeon
Date: Wed Jan 09 2013 - 01:26:29 EST


2012/12/13, Namjae Jeon <linkinjeon@xxxxxxxxx>:
> 2012/10/19, Namjae Jeon <linkinjeon@xxxxxxxxx>:
>> 2012/10/19, Jan Kara <jack@xxxxxxx>:
>>> Hello,
>>>
>>> On Wed 10-10-12 00:10:01, Namjae Jeon wrote:
>>>> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>>>>
>>>> This patch implements extent caching.
>>>> Instead of reading metadata everytime from file's starting position,
>>>> now we read from the cached extent.
>>>> This speeds up the transformation of file logical offsets to
>>>> corresponding on-disk blocks.
>>> I have some mostly minor comments to the patch. But when reading the
>>> extent code it is just ugly and hard to follow. So I'm thinking how to
>>> improve that before making things even harder with the extent cache. So
>>> give me a few more days please.
>> Hi Jan.
>> Okay, I see. Thanks!
>>>
> Hi Jan.
> Sorry for interrupt. I am still waiting for your review.
> Would you check extent cache patches ?
> Thanks.
Hi Jan.

Maybe You think you didn't convince extent cache implementation of
write part in this patch.
So I suggest that once, we add extent cache of read part first in case
of read-only mount type.
because it is real issue on 3D BD-disk playing(BD Disk is used on
read-only mount type).
And I will check more write part again.

Thanks.

>
>>> Honza
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/