RE: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware inalternate place

From: Bing Zhao
Date: Tue Jan 08 2013 - 21:43:26 EST



> > linux-firmware ships the sd8688* firmware images that are shared with
> > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both places
> > and so should we.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> > ---
> > drivers/bluetooth/btmrvl_sdio.c | 24 ++++++++++++++++++++++--
> > drivers/bluetooth/btmrvl_sdio.h | 6 ++++--
> > 2 files changed, 26 insertions(+), 4 deletions(-)
>
> NAK from me on this one. I do not want the driver to check two
> locations. That is what userspace can work around.
>
> If we want to unify the location between the WiFi driver and the
> Bluetooth driver, I am fine with that, but seriously, just pick one over
> the other. I do not care which one.

The unified location is mrvl/ directory.

We can probably move SD8688 firmware & helper binaries to mrvl/ and have both drivers grab the images there?

Regards,
Bing

¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_