Re: [PATCH] target: initialize sense_reason_t ret incore_scsi3_emulate_pro_register()

[Nicholas A. Bellinger]

Hi Geert,

Apologies for the delay on this one.  Still catching up on some older
holiday items..

On Sat, 2012-12-22 at 22:15 +0100, Geert Uytterhoeven wrote:
> drivers/target/target_core_pr.c: In function âcore_scsi3_emulate_pro_registerâ:
> drivers/target/target_core_pr.c:2056: warning: âretâ may be used uninitialized in this function
> 
> If !spec_i_pt, the "goto out_put_pr_reg" on line 2141 seems to be a real
> case where ret is not initialized.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
>  drivers/target/target_core_pr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
> index e35dbf8..c2e8026 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -2053,7 +2053,7 @@ core_scsi3_emulate_pro_register(struct se_cmd *cmd, u64 res_key, u64 sa_res_key,
>  	/* Used for APTPL metadata w/ UNREGISTER */
>  	unsigned char *pr_aptpl_buf = NULL;
>  	unsigned char isid_buf[PR_REG_ISID_LEN], *isid_ptr = NULL;
> -	sense_reason_t ret;
> +	sense_reason_t ret = 0;
>  	int pr_holder = 0, type;
>  
>  	if (!se_sess || !se_lun) {

Looks fine, applied to target-pending/master.

Thank you,

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/