Re: [PATCH 07/12] VMCI: queue pairs implementation.

[Greg KH]

On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
> VMCI queue pairs allow for bi-directional ordered communication between host and guests.

You should wrap your commit lines at 72 characters, like git asks you to :)

> +/* Guest device port I/O. */
> +struct PPNSet {
> +	u64 num_produce_pages;
> +	u64 num_consume_pages;
> +	u32 *produce_ppns;
> +	u32 *consume_ppns;
> +	bool initialized;
> +};

I know this is a private structure to the driver, so it's not that big
of a deal at all, but the naming for this is a bit odd (mixed case.)

Not a show stopper at all, but if you had run checkpatch.pl on it, it
would have warned you about this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/