Re: [PATCH][RESEND] staging: zram: fix invalid memory referencesduring disk write

From: Greg KH
Date: Tue Jan 08 2013 - 17:13:02 EST


On Tue, Jan 08, 2013 at 02:00:27PM -0800, Nitin Gupta wrote:
> On Fri, Jan 4, 2013 at 12:25 PM, Nitin Gupta <ngupta@xxxxxxxxxx> wrote:
> > On Wed, Jan 2, 2013 at 8:53 AM, Nitin Gupta <ngupta@xxxxxxxxxx> wrote:
> >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling
> >> of incompressible pages") which caused invalid memory references
> >> during disk write. Invalid references could occur in two cases:
> >> - Incoming data expands on compression: In this case, reference was
> >> made to kunmap()'ed bio page.
> >> - Partial (non PAGE_SIZE) write with incompressible data: In this
> >> case, reference was made to a kfree()'ed buffer.
> >>
> >> Fixes bug 50081:
> >> https://bugzilla.kernel.org/show_bug.cgi?id=50081
> >>
> >
> > Greg: can you please add this to staging? It fixes an important issue
> > and is tested by many users.
> >
>
>
> It's still not in staging. Any reason why you want to accept this patch?

Because I'm still catching up after being on vacation for 3 weeks? I
only got back yesterday and have a few thousand emails/patches to make
it through. Patches for staging drivers are way down on the list of
priorities for me, especially the zram/zcache/zwhatever mess that we
currently have...

Don't worry, it's not lost, and will make it in soon, please give me a
chance.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/