Re: [PATCH 2/2] cgroups: fix cgroup_event_listener error handling

From: Tejun Heo
Date: Tue Jan 08 2013 - 13:08:21 EST


On Tue, Jan 08, 2013 at 02:28:44PM +0800, Li Zefan wrote:
> > cgroups: fix cgroup_event_listener error handling
> >
> > The error handling in cgroup_event_listener.c did not correctly deal
> > with either an error opening either <control_file> or
> > cgroup.event_control. Due to an uninitialized variable the program
> > exit code was undefined if either of these opens failed.
> >
> > This patch simplifies and corrects cgroup_event_listener.c error
> > handling by:
> > 1. using err*() rather than printf(),exit()
> > 2. depending on process exit to close open files
> >
> > With this patch failures always return non-zero error.
> >
> > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>
>
> Acked-by: Li Zefan <lizefan@xxxxxxxxxx>

Applied to cgroup/for-3.9.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/