Re: [PATCH] pps: hide more configuration symbols behind CONFIG_PPS

From: Richard Cochran
Date: Tue Jan 08 2013 - 11:27:55 EST


On Tue, Jan 08, 2013 at 01:59:22PM +0100, Florian Fainelli wrote:
> This patch makes CONFIG_PPS_DEBUG and CONFIG_NTP_PPS be hidden if
> CONFIG_PPS is not selected, such that we are not prompted for these
> configuration options if CONFIG_PPS is not set.
>
> Signed-off-by: Florian Fainelli <florian@xxxxxxxxxxx>
> ---
> drivers/pps/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig
> index 982d16b..dc19fb4 100644
> --- a/drivers/pps/Kconfig
> +++ b/drivers/pps/Kconfig
> @@ -21,6 +21,8 @@ config PPS
> To compile this driver as a module, choose M here: the module
> will be called pps_core.ko.
>
> +if PPS
> +

If you add this "if" ...

> config PPS_DEBUG
> bool "PPS debugging messages"
> depends on PPS

... then you should delete this redundant "depends".

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/