Re: [PATCH 7/7] uprobes: Kill the bogus IS_ERR_VALUE(xol_vaddr)check

[Srikar Dronamraju]

* Oleg Nesterov <oleg@xxxxxxxxxx> [2012-12-31 18:52:32]:

> utask->xol_vaddr is either zero or valid, remove the bogus
> IS_ERR_VALUE() check in xol_free_insn_slot().
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

> ---
>  kernel/events/uprobes.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index ad1245d..ed4fcbe 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -1223,8 +1223,7 @@ static void xol_free_insn_slot(struct task_struct *tsk)
>  		return;
> 
>  	slot_addr = tsk->utask->xol_vaddr;
> -
> -	if (unlikely(!slot_addr || IS_ERR_VALUE(slot_addr)))
> +	if (unlikely(!slot_addr))
>  		return;
> 
>  	area = tsk->mm->uprobes_state.xol_area;
> -- 
> 1.5.5.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/