Re: [PATCH] Added NIST CMAC to the CryptoAPI library

[Steffen Klassert]

On Tue, Dec 11, 2012 at 02:00:10PM -0500, Tom St Denis wrote:
> This patch adds NIST CMAC cipher based MAC as described in FIPS 800-38B to
> the CryptoAPI stack.  It also wires up the MAC to the IPsec stack as per
> RFC 4494.
> 
> This patch was tested against 3.7 with third party hardware IPsec.
> 
> Signed-off-by: Tom St Denis <tstdenis@xxxxxxxxxxxxxxxx>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 

I agreed with Herbert Xu to integrate this via the ipsec-next tree.

However, it introduces the following warning:

crypto/cmac.c: In function âcrypto_cmac_digest_setkeyâ:
crypto/cmac.c:97:4: warning: suggest parentheses around arithmetic in
operand of â^â [-Wparentheses]

It also has a lot of coding style issues, run checkpatch.

Please fix it and resend.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/