Re: [PATCH 1/2] staging: usbip: use interrupt safe spinlock to avoidpotential deadlock.

From: Greg Kroah-Hartman
Date: Tue Jan 08 2013 - 00:50:54 EST

Next message: Greg Kroah-Hartman: "Re: [PATCH 0/2] staging: usbip: refine the lock"
Previous message: ZhangYi: "[PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment"
In reply to: Harvey Yang: "[PATCH 1/2] staging: usbip: use interrupt safe spinlock to avoid potential deadlock."
Next in thread: Harvey Yang: "[PATCH 2/2] staging: usbip: replace the interrupt safe spinlocks with common ones."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Jan 08, 2013 at 01:49:01PM +0800, Harvey Yang wrote:
>
> Signed-off-by: Harvey Yang <harvey.huawei.yang@xxxxxxxxx>

You need to describe _why_ you did this, not just what you did. Why is
this needed? What are you fixing by doing this? Is this something that
older kernels need? Is it something that others are seeing?

Same goes for patch 2/2 here, you have to provide a good changelog entry
in order for this to be accepted.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Greg Kroah-Hartman: "Re: [PATCH 0/2] staging: usbip: refine the lock"
Previous message: ZhangYi: "[PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment"
In reply to: Harvey Yang: "[PATCH 1/2] staging: usbip: use interrupt safe spinlock to avoid potential deadlock."
Next in thread: Harvey Yang: "[PATCH 2/2] staging: usbip: replace the interrupt safe spinlocks with common ones."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]