Re: [PATCH 2/2] Staging: comedi: addi_common.h: checkpatch.pl fixes

[Lijo Antony]

On 01/08/2013 02:50 AM, H Hartley Sweeten wrote:
> On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
> > On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
> > > Reduced line lengths to 80 chars by removing extra spaces.
> > >
> > > Signed-off-by: Lijo Antony <lijo.kernel@xxxxxxxxx>
> > > ---
> > >   .../staging/comedi/drivers/addi-data/addi_common.h |   20 ++++++++++----------
> > >   1 file changed, 10 insertions(+), 10 deletions(-)
>
> <snip>
>
> > As you didn't do this for all fields in the structure, it's not really
> > worth doing it for just these, right?
> >
> > The proper thing to do is use kerneldoc format and document it all at
> > the top of the structure, care to do that instead?
>
> Hopefully I will soon get the rest of the addi-data drivers split off of the
> addi_common stuff. This will effectively remove this header file so I'm
> not sure it's worth making patches against it.

Ok, I will wait!
If the file is still around after your cleanup, I will make changes as 
per Greg's suggestion.

Thanks,
-lijo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/