Re: linux-next: comment in commit in the slave-dma tree (dmaengine:dw_dmac: Enhance device tree support)

[Stephen Rothwell]

Hi Greg,

On Mon, 7 Jan 2013 14:43:08 -0800 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> That brings up something I wanted to ask you.
> 
> I'd like to send a patch to Linus to just delete __devinit and friends
> entirely from init.h, but that will break the linux-next tree from
> building in places (like this one, and in a few others.)
> 
> Is that ok?  That should finally get everyone's attention and keep them
> from the cargo-cult programming mode of using these attributes :)

I guess I can apply fixup patches that just remove any instances that
turn up ... and you and the tree owner will get copies of those.

So, if Linus takes it, I will cope.

This is what "git grep -E '__dev(init|exit)'" returns for next-20130107:

arch/ia64/kernel/iosapic.c: *				__init/__devinit attributes.
drivers/dma/dw_dmac.c:__devinit dw_dma_parse_dt(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:static int __devinit sh_veu_probe(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:static int __devexit sh_veu_remove(struct platform_device *pdev)
drivers/media/platform/sh_veu.c:	.remove		= __devexit_p(sh_veu_remove),
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:static int __devinit
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:static void __devexit qlcnic_remove(struct pci_dev *pdev)
drivers/power/reset/restart-poweroff.c:static int __devinit restart_poweroff_probe(struct platform_device *pdev)
drivers/power/reset/restart-poweroff.c:static int __devexit restart_poweroff_remove(struct platform_device *pdev)
drivers/power/reset/restart-poweroff.c:	.remove = __devexit_p(restart_poweroff_remove),
drivers/regulator/lp8755.c:	.remove = __devexit_p(lp8755_remove),
drivers/scsi/ipr.c:static int __devinit ipr_enable_msix(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static int __devinit ipr_enable_msi(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static void __devinit name_msi_vectors(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ipr.c:static int __devinit ipr_request_other_msi_irqs(struct ipr_ioa_cfg *ioa_cfg)
drivers/scsi/ips.c:/* 5.30.00  - use __devexit_p()                                              */
scripts/tags.sh:	-I __initdata,__exitdata,__initconst,__devinitdata	\
scripts/tags.sh:	-I __devinitconst,__cpuinitdata,__initdata_memblock	\
sound/oss/swarm_cs4297a.c:* 11/10/00 bkz - added __devinit to cs4297a_hw_init()

so there are just a few left.

BTW, I am *not* reporting merge fixes I am doing due to your tree wide
removal of __dev*, but they are still turning up :-(

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature