Re: [PATCH] omap: am33xx-hwmod: Fix wrongly terminatedam33xx_usbss_mpu_irqs array

From: Tony Lindgren
Date: Mon Jan 07 2013 - 15:03:29 EST


* Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> [130103 14:35]:
> The IRQ array must be terminated by -1 and not by -1+OMAP_INTC_START
> This led to having a resource list of 100s of IRQs.

This is a bug for sure introduced with commit a2cfc509 (ARM: OMAP3+:
hwmod: Add AM33XX HWMOD data). Anybody care to ack this one?

Regards,

Tony

> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 081c71e..e402303 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -2070,7 +2070,7 @@ static struct omap_hwmod_irq_info am33xx_usbss_mpu_irqs[] = {
> { .name = "usbss-irq", .irq = 17 + OMAP_INTC_START, },
> { .name = "musb0-irq", .irq = 18 + OMAP_INTC_START, },
> { .name = "musb1-irq", .irq = 19 + OMAP_INTC_START, },
> - { .irq = -1 + OMAP_INTC_START, },
> + { .irq = -1, },
> };
>
> static struct omap_hwmod am33xx_usbss_hwmod = {
> --
> 1.7.12
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/