Re: [PATCH v7u1 03/31] x86, realmode: set real_mode permissions early

[Borislav Petkov]

On Fri, Jan 04, 2013 at 02:13:11PM -0800, Yinghai Lu wrote:
> On Fri, Jan 4, 2013 at 1:04 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> > On Fri, Jan 04, 2013 at 12:58:15PM -0800, Yinghai Lu wrote:
> >> more than that, that set_real_mode_permissions reference is wrong,
> >> actually it is set_real_mode.
> >
> > Huh, set_real_mode_permissions is the name of the function above which the
> > comment is located. There's no set_real_mode. What do you mean?
> 
> old comments is wrong.
> 
> setup_read_mode reserve from low ram under 1M and copy etc.
> 
> set_real_mode_permissions will change to +x etc....

Ok, let me shout it out to you, hopefully you can understand me now:

THERE ARE NO FUNCTIONS BY THE NAME setup_read_mode OR set_real_mode IN
YOUR BRANCH OR ANYWHERE IN THE KERNEL!!!

$ git log -p yinghai/for-x86-boot-v7 | grep -EriIn '(setup_read_mode|set_real_mode)\W'
$ git log -p yinghai/for-x86-boot-v8 | grep -EriIn '(setup_read_mode|set_real_mode)\W'
$

Or do you mean that the function naming is wrong? WTF?

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/