Re: [PATCH v7u1 04/31] x86, 64bit, mm: add generic kernel/identmapping helper

[Yinghai Lu]

On Fri, Jan 4, 2013 at 1:19 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Thu, Jan 03, 2013 at 04:48:24PM -0800, Yinghai Lu wrote:
>> +int kernel_mapping_init(pgd_t *pgd_page, unsigned long addr, unsigned long end)
>> +{
>> +     struct x86_mapping_info info = {
>> +             .alloc_pgt_page = alloc_pgt_page,
>> +             .pmd_flag       = __PAGE_KERNEL_LARGE,
>> +             .kernel_mapping = true,
>> +     };
>> +
>> +     return kernel_ident_mapping_init(&info, pgd_page, addr, end);
>
> This patch looks good so far except this:
> kernel_ident_mapping_init says it initializes ident mapping but
> this is wrong and the type of mapping is actually controlled by
> info.kernel_mapping.

it is not wrong, and it could do two things.
kernel_mapping
ident_mapping


>
> So this function which gets &info, etc should be called
> kernel_mapping_init, AFAICT. And wrt the one wrapping
> kernel_ident_mapping_init, I can't seem to find where it is called.
> What's up?

this kernel_mapping_init is for -v8 ..., should be dropped if -v7 is
used at last.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/