Re: [PATCH v7u1 01/31] x86, mm: Fix page table early allocationoffset checking

[Yinghai Lu]

On Thu, Jan 3, 2013 at 11:17 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Thu, Jan 03, 2013 at 04:48:21PM -0800, Yinghai Lu wrote:
>> During debugging loading kernel above 4G, found one page if is not used
>> in BRK with early page allocation.
>>
>> pgt_buf_top is address that can not be used, so should check if that new
>> end is above that top, otherwise last page will not be used.
>>
>> Fix that checking and also add print out for every allocation from BRK.
>
> This commit message still bothers the hell out of me. Please, fix it up
> to something more readable like the below, for example:
>
> "pgt_buf_top is an address which cannot be used so we should check
> whether the new 'end' is above it. Otherwise, the last BRK page remains
> unused.
>
> Fix that check and add a debug printout of every BRK allocation."

but your changelog is wrong.

it is NOT last BRK page.

it is NOT every BRK allocation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/