Re: [PATCH] nfsd: Remove write permission from file content

[J. Bruce Fields]

On Fri, Jan 04, 2013 at 07:45:35PM +0800, ycnian@xxxxxxxxx wrote:
> From: Yanchuan Nian <ycnian@xxxxxxxxx>
> 
> The write function doesn't be implemented in file content, and it's meaningless
> to write data into this file directly. Remove write permission from it.

So does it really matter either way?

OK, applying, but I wonder.

--b.

> 
> Signed-off-by: Yanchuan Nian <ycnian@xxxxxxxxx>
> ---
>  net/sunrpc/cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 9afa439..9f84703 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1614,7 +1614,7 @@ static int create_cache_proc_entries(struct cache_detail *cd, struct net *net)
>  			goto out_nomem;
>  	}
>  	if (cd->cache_show) {
> -		p = proc_create_data("content", S_IFREG|S_IRUSR|S_IWUSR,
> +		p = proc_create_data("content", S_IFREG|S_IRUSR,
>  				cd->u.procfs.proc_ent,
>  				&content_file_operations_procfs, cd);
>  		cd->u.procfs.content_ent = p;
> -- 
> 1.7.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/