Re: [PATCH v3 3/8] MFD:rtsx: Declare that the DMA addresslimitationis32bit explicitly

[Dan Carpenter]

On Fri, Jan 04, 2013 at 10:46:22AM +0800, wwang wrote:
> ä 2013å01æ03æ 20:25, Dan Carpenter åé:
> > On Fri, Dec 28, 2012 at 10:41:28AM +0800, wei_wang@xxxxxxxxxxxxxx wrote:
> >> From: Wei WANG <wei_wang@xxxxxxxxxxxxxx>
> >>
> >> Realtek PCIe card reader only supports 32bit DMA
> >>
> > Is this a bugfix?  If so what does the bug look like?
> >
> > regards,
> > dan carpenter
> >
> Hi Dan:
> 
> No, this is not a bugfix. In default, the kernel will allocate 32bit
> address for DMA. This declaration can improve the readability.
> 

Ah ok.  Really none of the things I mentioned were stuff that
prevented the patch from being merged or couldn't be fixed in follow
on patches.

The thing is that the commit message should always say why a patch
is needed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/