Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage ofIS_ERR_OR_NULL

From: Dan Carpenter
Date: Thu Jan 03 2013 - 06:11:20 EST


Come on... Don't say we haven't read comment. Obviously, the first
thing we did was read that comment. I've read it many times at this
point and I still think we should add in a bit which says:

"NOTE: Drivers should treat the return value as an opaque cookie
and not dereference it. NULL returns don't imply an error so don't
use IS_ERR_OR_NULL() to check for errors."

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/