clk dereference in drivers/net/ethernet/ti/cpts.c

From: Julia Lawall
Date: Thu Jan 03 2013 - 05:20:43 EST


There has been a discussion recently about how the result of get_clk
should be an opaque handle, not a value that can be dereferenced:

https://lkml.org/lkml/2012/12/20/105

There is such a dereference in drivers/net/ethernet/ti/cpts.c, in the
function cpts_clk_init:

cpts->freq = cpts->refclk->recalc(cpts->refclk);

It was not obvious to me, however, what API function should be used
instead, so I am just reporting the (potential) problem.

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/