Re: [PATCH 1/3] HID: introduce helper for hid_driver boilerplate

From: Jiri Kosina
Date: Thu Jan 03 2013 - 04:33:50 EST


On Mon, 17 Dec 2012, H Hartley Sweeten wrote:

> Introduce the module_hid_driver macro which is a convenience macro
> for HID driver modules similar to module_usb_driver. It is intended
> to be used by drivers with init/exit sections that do nothing but
> register/unregister the HID driver.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> ---
> include/linux/hid.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 7330a0f..d6c71a6 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -700,6 +700,18 @@ extern int __must_check __hid_register_driver(struct hid_driver *,
>
> extern void hid_unregister_driver(struct hid_driver *);
>
> +/**
> + * module_hid_driver() - Helper macro for registering a HID driver
> + * @__hid_driver: hid_driver struct
> + *
> + * Helper macro for HID drivers which do not do anything special in module
> + * init/exit. This eliminates a lot of boilerplate. Each module may only
> + * use this macro once, and calling it replaces module_init() and module_exit()
> + */
> +#define module_hid_driver(__hid_driver) \
> + module_driver(__hid_driver, hid_register_driver, \
> + hid_unregister_driver)
> +
> extern void hidinput_hid_event(struct hid_device *, struct hid_field *, struct hid_usage *, __s32);
> extern void hidinput_report_event(struct hid_device *hid, struct hid_report *report);
> extern int hidinput_connect(struct hid_device *hid, unsigned int force);

Applied, thanks.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/