Re: [PATCH v2] lib: cpu_rmap: avoid flushing all workqueues

[Ben Hutchings]

On Fri, 2012-12-28 at 13:14 -0800, Eric Dumazet wrote:
[...]
> > +/**
> > + * reclaim_cpu_rmap - internal reclaiming helper called from kref_put
> > + * @ref: kref to struct cpu_rmap
> > + */
> > +static void reclaim_cpu_rmap(struct kref *ref)
> 
> Could be named cpu_rmap_free()
> 
> (and alloc_cpu_rmap() should be renamed as cpu_rmap_alloc()
[...]

There are many other APIs that include alloc_foo() and free_foo().  I'm
not aware of any convention that this should be avoided in new APIs (not
that this is new any more).

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/