Re: [PATCH v4] rtc: add new lp8788 rtc driver

From: devendra.aaru
Date: Wed Jan 02 2013 - 01:46:19 EST


On Wed, Jan 2, 2013 at 1:30 AM, Kim, Milo <Milo.Kim@xxxxxx> wrote:
> TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver
> and current sinks.
> This patch enables LP8788 rtc module.
>
> Patch v4.
> when alarm IRQ number is not specified, RTC_AIE_ON ioctl returns as -EIO
> remove unnecessary platform data check routine
> fix wrong parent device pointer in _probe(): use '&pdev->dev'
> fix return value when rtc_device_register() gets failed: use PTR_ERR()
>
> Patch v3.
> remove __devinit and __devexit
> add weekday definition and comments
>
> Patch v2.
> use irq domain for handling alarm IRQ
> replace module_init() and module_exit() with module_platform_driver()
> clean up code for _probe() and _remove()
>
> Patch v1.
> initial patch
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
> ---
> drivers/rtc/Kconfig | 6 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-lp8788.c | 344 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 351 insertions(+)
> create mode 100644 drivers/rtc/rtc-lp8788.c

Thanks for taking care of the comments!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/