Re: [PATCH V2] Fix problem with cpufreq_ondemand or cpufreq_conservative

[Larry Finger]

On 01/01/2013 09:56 PM, Viresh Kumar wrote:
> I know, V4 is already accepted, but i had an small comment with one
> of your earlier change, which doesn't exist anymore :)
>
> On Sat, Dec 29, 2012 at 5:51 AM, Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> > Index: wireless-testing-new/drivers/cpufreq/cpufreq_governor.c
>
> How are you creating these patches? wireless-testing-new (linux directory names)
> aren't supposed to be present here.
>
> > ===================================================================
> > --- wireless-testing-new.orig/drivers/cpufreq/cpufreq_governor.c
> > +++ wireless-testing-new/drivers/cpufreq/cpufreq_governor.c
> > @@ -316,3 +316,8 @@ second_time:
> >          return 0;
> >   }
> >   EXPORT_SYMBOL_GPL(cpufreq_governor_dbs);
> > +
> > +MODULE_AUTHOR("Alexander Clouter <alex@xxxxxxxxxxxxx>");
>
> You shouldn't be adding yourself as author here :)
>
> MODULE_AUTHOR("Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>");
> MODULE_AUTHOR("Alexey Starikovskiy <alexey.y.starikovskiy@xxxxxxxxx>");

I was not adding myself - my name is not Alexander Clouter. When we were 
creating a new module, I got the author from the module that cpufreq_governor 
was originally a part. Perhaps I got the name wrong.

Thanks for the review mentioned in the next Email.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/