Re: 3.8-rc1 build failure with MIPS/SPARSEMEM

From: Kirill A. Shutemov
Date: Sun Dec 30 2012 - 05:37:49 EST


On Thu, Dec 27, 2012 at 02:16:07PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Dec 26, 2012 at 02:34:35AM +0200, Kirill A. Shutemov wrote:
> > On MIPS if SPARSEMEM is enabled we've got this:
> >
> > In file included from /home/kas/git/public/linux/arch/mips/include/asm/pgtable.h:552,
> > from include/linux/mm.h:44,
> > from arch/mips/kernel/asm-offsets.c:14:
> > include/asm-generic/pgtable.h: In function âmy_zero_pfnâ:
> > include/asm-generic/pgtable.h:466: error: implicit declaration of function âpage_to_sectionâ
> > In file included from arch/mips/kernel/asm-offsets.c:14:
> > include/linux/mm.h: At top level:
> > include/linux/mm.h:738: error: conflicting types for âpage_to_sectionâ
> > include/asm-generic/pgtable.h:466: note: previous implicit declaration of âpage_to_sectionâ was here
> >
> > Due header files inter-dependencies, the only way I see to fix it is
> > convert my_zero_pfn() for __HAVE_COLOR_ZERO_PAGE to macros.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
>
> Thanks, this works.
>
> Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

Andrew, could you take the patch?

--
Kirill A. Shutemov

Attachment: signature.asc
Description: Digital signature