Re: [PATCH RFC] PM/Devfreq: Add Exynos5-bus devfreq driver forExynos5250.

From: Olof Johansson
Date: Sun Dec 30 2012 - 01:18:29 EST


Hi,

On Tue, Dec 11, 2012 at 10:20:51AM +0900, MyungJoo Ham wrote:
> On Fri, Nov 30, 2012 at 5:42 PM, Abhilash Kesavan <a.kesavan@xxxxxxxxxxx> wrote:
> > drivers/devfreq/Kconfig | 10 +
> > drivers/devfreq/Makefile | 1 +
> > drivers/devfreq/exynos5_bus.c | 595 ++++++++++++++++++++++++++++++++++++++++
> > drivers/devfreq/exynos5_ppmu.c | 395 ++++++++++++++++++++++++++
> > drivers/devfreq/exynos5_ppmu.h | 26 ++
> > drivers/devfreq/exynos_ppmu.c | 56 ++++
> > drivers/devfreq/exynos_ppmu.h | 79 ++++++
> > 7 files changed, 1162 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/devfreq/exynos5_bus.c
> > create mode 100644 drivers/devfreq/exynos5_ppmu.c
> > create mode 100644 drivers/devfreq/exynos5_ppmu.h
> > create mode 100644 drivers/devfreq/exynos_ppmu.c
> > create mode 100644 drivers/devfreq/exynos_ppmu.h
>
> I understand that Exynos PPMU drivers seem not to be used (at least in
> mainline Linux) widely and it'd be convinent for a bus driver to have
> ppmu driver located in the same source directory.
>
> However, I don't feel very comfortable to have ppmu drivers explicitly
> landing in devfreq directory. Would it be possible to place them
> somewhere else? (in drivers/misc, arch/arm/mach-exynos, or somewhere
> appropriate?) If PPMU drivers really have nowhere to relocate, they
> may be located along with its sole user (exynos5_bus.c) anyway.

Why can't they be in drivers/busfreq? Create a subdirectory for
platform-specific subdrivers if needed, but they definitiely do NOT
belong in drivers/misc, and there seems to be little reason to have them
in arch/arm.



-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/