Re: [ 016/173] use clamp_t in UNAME26 fix

From: Ben Hutchings
Date: Sat Dec 29 2012 - 06:01:30 EST


On Sat, 2012-12-29 at 00:07 -0800, Jonathan Nieder wrote:
> Ben Hutchings wrote:
>
> > The min/max call needed to have explicit types on some architectures
> > (e.g. mn10300). Use clamp_t instead to avoid the warning:
> >
> > kernel/sys.c: In function 'override_release':
> > kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a cast [enabled by default]
> >
> > Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> [...]
> > - copy = min(sizeof(buf), max_t(size_t, 1, len));
>
> I don't understand how this happens given that v2.6.36-rc1~68
> (MN10300: Fix size_t and ssize_t, 2010-08-12) was supposed to fix this
> kind of thing.
[...]

Neither do I, but I'm including it now just to be consistent with other
stable series.

Ben.

--
Ben Hutchings
It is easier to change the specification to fit the program than vice versa.

Attachment: signature.asc
Description: This is a digitally signed message part