Re: [PATCH 07/25] mwifiex: don't use [delayed_]work_pending()

From: Tejun Heo
Date: Fri Dec 28 2012 - 16:41:11 EST


On Sat, Dec 22, 2012 at 02:29:57PM -0800, Bing Zhao wrote:
> Hi Tejun,
>
> Thanks for the patch.
>
> > Drop work_pending() test from mwifiex_sdio_card_reset(). As
> > work_pending() becomes %false before sdio_card_reset_worker() starts
> > executing, it doesn't really protect anything. reset_host may change
> > between mmc_remove_host() and mmc_add_host(). Make
> > sdio_card_reset_worker() cache the target mmc_host so that it isn't
> > affected by mwifiex_sdio_card_reset() racing with it.
> >
> > Only compile tested.
> >
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: Bing Zhao <bzhao@xxxxxxxxxxx>
> > Cc: linux-wireless@xxxxxxxxxxxxxxx
>
> Acked-by: Bing Zhao <bzhao@xxxxxxxxxxx>
>
> > ---
> > Please let me know how this patch should be routed. I can take it
> > through the workqueue tree if necessary.
>
> If you are taking other patches in this series through your tree, please take this one too.

Applied to wq/for-3.9-cleanups.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/