Re: [PATCH] get_maintainer.pl: Find maintainers for removed files

From: Joe Perches
Date: Fri Dec 28 2012 - 15:00:11 EST


On Fri, 2012-12-28 at 20:27 +0100, Geert Uytterhoeven wrote:
> For removed files, get_maintainer.pl doesn't find any maintainers (besides
> the default linux-kernel@xxxxxxxxxxxxxxx), as it only looks at the "+++"
> lines, which are "/dev/null" for removals.
> Fix this by extending the parsing to the "---" lines.
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -433,7 +433,7 @@ foreach my $file (@ARGV) {
>
> while (<$patch>) {
> my $patch_line = $_;
> - if (m/^\+\+\+\s+(\S+)/) {
> + if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
> my $filename = $1;
> $filename =~ s@^[^/]*/@@;
> $filename =~ s@\n@@;

OK, but this would now match any keyword in a deleted filename.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/