Re: [PATCH] x86, mm: add generic kernel/ident mapping helper

[Yinghai Lu]

On Thu, Dec 27, 2012 at 4:34 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Thu, Dec 27, 2012 at 10:51 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
>>> +struct mapping_info {
>>> +     void *(*alloc)(void *);
>>
>>                 alloc_page
>
> alloc_page make me feel that it will return struct page *.

also will get error

arch/x86/mm/init_64.c: In function ‘ident_pud_init’:
arch/x86/mm/init_64.c:88:22: error: ‘struct mapping_info’ has no
member named ‘alloc_pages’
arch/x86/mm/init_64.c: In function ‘kernel_ident_mapping_init’:
arch/x86/mm/init_64.c:121:22: error: ‘struct mapping_info’ has no
member named ‘alloc_pages’

because include/linux/gfp.h has

#define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0)

so will stay with alloc.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/