Re: [PATCH 2/3] mm, bootmem: panic in bootmem alloc functions evenif slab is available

From: Sasha Levin
Date: Thu Dec 27 2012 - 18:08:23 EST


On 12/27/2012 06:04 PM, David Rientjes wrote:
> On Thu, 27 Dec 2012, Sasha Levin wrote:
>
>> That's exactly what happens with the patch. Note that in the current upstream
>> version there are several slab checks scattered all over.
>>
>> In this case for example, I'm removing it from __alloc_bootmem_node(), but the
>> first code line of__alloc_bootmem_node_nopanic() is:
>>
>> if (WARN_ON_ONCE(slab_is_available()))
>> return kzalloc(size, GFP_NOWAIT);
>>
>
> You're only talking about mm/bootmem.c and not mm/nobootmem.c, and notice
> that __alloc_bootmem_node() does not call __alloc_bootmem_node_nopanic(),
> it calls ___alloc_bootmem_node_nopanic().

Holy cow, this is an underscore hell.


Thanks,
Sasha

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/