Re: [PATCH BUGFIX] pkt_sched: fix little service anomalies andpossible crashes of qfq+

From: David Miller
Date: Wed Dec 26 2012 - 18:13:45 EST


From: Paolo valente <paolo.valente@xxxxxxxxxx>
Date: Wed, 19 Dec 2012 18:31:06 +0100

> + /*
> + * The next assignment may let
> + * agg->initial_budget > agg->budgetmax
> + * hold, but this does not cause any harm
> + */

Please format comments in the networking:

/* Like
* this.
*/

and

/*
* Never
* like this.
*/

I know this file is full of exceptions, but that error is to be
corrected rather than expanded.

> + /*
> + * If lmax is lowered, through qfq_change_class, for a class
> + * owning pending packets with larger size than the new value of lmax,
> + * then the following condition may hold.
> + */

Likewise.

And I'm not applying this until someone familiar with this code
does some review of this patch. These are seriously non-trivial
changes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/