Re: [PATCH] block: Remove should_sort judgement when flush blk_plug.

[Jens Axboe]

On 2012-12-25 10:27, majianpeng wrote:
> In commit 975927b942c932,it add blk_rq_pos to sort rq when flushing.
> Although this commit was used for the situation which blk_plug handled
> multi devices on the same time like md device.
> I think there must be some situations like this but only single
> device.
> So remove the should_sort judgement.
> Because the parameter should_sort is only for this purpose,it can delete
> should_sort from blk_plug.

Agree with the patch. It does not make sense to have ->should_sort and
not set it for all the conditions that the list_sort() compare now
checks for.

Applied for 3.9, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/