Re: [PATCH 1/5] f2fs: Introduce some information prints in themount path

From: Joe Perches
Date: Wed Dec 26 2012 - 03:17:14 EST


On Wed, 2012-12-26 at 13:22 +0900, Namjae Jeon wrote:
> 2012/12/26, Joe Perches <joe@xxxxxxxxxxx>:
> > On Wed, 2012-12-26 at 11:10 +0900, Namjae Jeon wrote:
> >> 2012/12/26, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>:
> >> > Could you make them follow the file system convention?
> >> > Something like "F2FS: blah blah~".
> >> Yes, I agree.
> >> > Otherwise, how about adding a debugging function to express the prefix?
> >> Okay, I will send you the patches included your suggestion.
> > Add
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > before any #include
> Hi Joe.

Hello Namjae

> I think we can have debugging message function for f2fs similar to
> ext4/fat like fat_msg, ext4_msg.
> It is one time change but in the future it will allow more convenience
> to use that way.
> What is your opinion ?
>
> Or is that we have to to use pr_xxx function for error print instead
> of own print debug function ?

Sure, make your own f2fs_dbg function/macro when
and if you have an object you want to pass along
with the format and args

something like:

fs2fs_printk(struct fs2fs_handle *f2h, const char *fmt, ...)

Otherwise, just use pr_debug/pr_<level>(fmt, ...)

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/