Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_sectionof sparse-vmemmap

[Tang Chen]

On 12/25/2012 04:09 PM, Jianguo Wu wrote:
> > +
> > +		if (!cpu_has_pse) {
> > +			next = (addr + PAGE_SIZE)&  PAGE_MASK;
> > +			pmd = pmd_offset(pud, addr);
> > +			if (pmd_none(*pmd))
> > +				continue;
> > +			get_page_bootmem(section_nr, pmd_page(*pmd),
> > +					 MIX_SECTION_INFO);
> > +
> > +			pte = pte_offset_kernel(pmd, addr);
> > +			if (pte_none(*pte))
> > +				continue;
> > +			get_page_bootmem(section_nr, pte_page(*pte),
> > +					 SECTION_INFO);
> > +		} else {
> > +			next = pmd_addr_end(addr, end);
> > +
> > +			pmd = pmd_offset(pud, addr);
> > +			if (pmd_none(*pmd))
> > +				continue;
> > +			get_page_bootmem(section_nr, pmd_page(*pmd),
> > +					 SECTION_INFO);
>
> Hi Tangï
> 	In this case, pmd maps 512 pages, but you only get_page_bootmem() on the first page.
> I think the whole 512 pages should be get_page_bootmem(), what do you think?
Hi Wu,

Yes, thanks. I will fix it. :)

Thanks. :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/