Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

[Jaegeuk Kim]

2012-12-25 (í), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
> 
>  CC      fs/f2fs/acl.o
> fs/f2fs/acl.c: In function âf2fs_acl_from_diskâ:
> fs/f2fs/acl.c:85:21: error: âstruct posix_acl_entryâ has no member named âe_idâ
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
> 
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids.  When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary.  Remove the assignment so f2fs will build with user
> namespaces enabled.
> 
> Cc: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>
> Cc: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> Cc: Amit Sahrawat <a.sahrawat@xxxxxxxxxxx>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Acked-by: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>

-- 
Jaegeuk Kim
Samsung

Attachment: signature.asc
Description: This is a digitally signed message part