Re: [PATCH] rtk_btusb: Add Bluetooth firmware

[Ben Hutchings]

On Thu, 2012-12-20 at 20:37 -0600, Larry Finger wrote:
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Signed-off-by: Champion Chen <champion_chen@xxxxxxxxxxxxxx>
> ---
>  WHENCE              |    8 ++++++++
>  rtl_bt/rtl8723a.bin |  Bin 0 -> 23772 bytes
>  2 files changed, 8 insertions(+)
>  create mode 100644 rtl_bt/rtl8723a.bin
> 
> diff --git a/WHENCE b/WHENCE
> index 3b2f282..f485111 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -1811,6 +1811,14 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>  
>  --------------------------------------------------------------------------
>  
> +Driver: rtk_btusb - Realtek Bluetooth driver
> +
> +Info: Supplied by champion_chen@xxxxxxxxxxxxxx along with driver source code
> +File: rtl_bt/rtl8723a.bin
> +
> +Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
[...]

There seem to be some serious problems with the driver that uses this.
So, if this is not already in use with an external firmware blob, could
you perhaps add some sort of header to the blob and have the driver make
some sanity checks before uploading to the device?

Ben.

-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug

Attachment: signature.asc
Description: This is a digitally signed message part